Implement CS checking based on the WP_CLI_CS ruleset#46
Merged
schlessera merged 13 commits intowp-cli:masterfrom Apr 19, 2019
thrijith:feature/use-phpcs
Merged
Implement CS checking based on the WP_CLI_CS ruleset#46schlessera merged 13 commits intowp-cli:masterfrom thrijith:feature/use-phpcs
WP_CLI_CS ruleset#46schlessera merged 13 commits intowp-cli:masterfrom
thrijith:feature/use-phpcs
Conversation
Update .distignore and .gitignore with phpcs/phpunit config files Update wp-cli-tests to 2.1
schlessera
requested changes
Apr 17, 2019
Update file exclude pattern in ruleset and minor fixes
Update code usage where namespace function was used
jrfnl
reviewed
Apr 19, 2019
src/Cron_Command.php
Outdated
| ), | ||
| ); | ||
| $cron_request = apply_filters( | ||
| 'cron_request', // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound -- 'cron_request', // phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound -- Calling native WordPress hook. |
There was a problem hiding this comment.
Something looks wrong here, two comments instead of just the one.
Suggestion:
// phpcs:ignore WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound -- Calling native WordPress hook.
$cron_request = apply_filters( 'cron_request', $cron_request_array );WP_CLI_CS ruleset
schlessera
requested changes
Apr 19, 2019
schlessera
approved these changes
Apr 19, 2019
danielbachhuber
pushed a commit
that referenced
this pull request
Nov 18, 2022
Implement CS checking based on the `WP_CLI_CS` ruleset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a PHPCS ruleset using the new
WPCliCSstandard.Fixes #44
Related wp-cli/wp-cli#5179