Implement CS checking based on the WP_CLI_CS ruleset#141
Merged
schlessera merged 23 commits intowp-cli:masterfrom Apr 21, 2019
Merged
Implement CS checking based on the WP_CLI_CS ruleset#141schlessera merged 23 commits intowp-cli:masterfrom
WP_CLI_CS ruleset#141schlessera merged 23 commits intowp-cli:masterfrom
Conversation
schlessera
requested changes
Apr 20, 2019
Member
=> replace => remove quotes around placeholders: => wrap in whitelist: // phpcs:disable WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedConstantFound
if ( ! defined( 'KB_IN_BYTES' ) ) {
define( 'KB_IN_BYTES', 1024 );
}
if ( ! defined( 'MB_IN_BYTES' ) ) {
define( 'MB_IN_BYTES', 1024 * KB_IN_BYTES );
}
if ( ! defined( 'GB_IN_BYTES' ) ) {
define( 'GB_IN_BYTES', 1024 * MB_IN_BYTES );
}
if ( ! defined( 'TB_IN_BYTES' ) ) {
define( 'TB_IN_BYTES', 1024 * GB_IN_BYTES );
}
// phpcs:enable(to be continued...) |
Member
=> Unsure why we have this there, let's leave it for now. Precede with whitelist comment: => Lines 1182, 1184, 1429 - I verified these are escaped, whitelist with a preceding comment: => Line 1429 - a slightly different comment explanation: => We can't change these, wrap block in whitelist: |
schlessera
requested changes
Apr 21, 2019
Co-Authored-By: wojsmol <wojsmol@wp.pl>
Co-Authored-By: wojsmol <wojsmol@wp.pl>
Co-Authored-By: wojsmol <wojsmol@wp.pl>
Co-Authored-By: wojsmol <wojsmol@wp.pl>
Co-Authored-By: wojsmol <wojsmol@wp.pl>
Co-Authored-By: wojsmol <wojsmol@wp.pl>
Co-Authored-By: wojsmol <wojsmol@wp.pl>
Co-Authored-By: wojsmol <wojsmol@wp.pl>
Co-Authored-By: wojsmol <wojsmol@wp.pl>
schlessera
requested changes
Apr 21, 2019
Co-Authored-By: wojsmol <wojsmol@wp.pl>
schlessera
requested changes
Apr 21, 2019
Co-Authored-By: wojsmol <wojsmol@wp.pl>
schlessera
approved these changes
Apr 21, 2019
Merged
danielbachhuber
pushed a commit
that referenced
this pull request
Nov 18, 2022
Implement CS checking based on the `WP_CLI_CS` ruleset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a PHPCS ruleset using the new WP_CLI_CS standard.
Fixes #139
Related wp-cli/wp-cli#5179