Fix category, tag and term names missing in export#86
Merged
schlessera merged 3 commits intomasterfrom Jul 25, 2021
Merged
Conversation
danielbachhuber
pushed a commit
that referenced
this pull request
Nov 18, 2022
Fix category, tag and term names missing in export
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A regression was introduced with #84 which was reported via #85.
The regression caused the
cat_name,tag_nameandterm_namevalues to be missing in the generated export.This PR removes the specific hardening that has introduced this regression, and adds a test scenario to ensure this will not happen again in the future.
Fixes #85