Implement CS checking based on the WP_CLI_CS ruleset#119
Merged
schlessera merged 4 commits intowp-cli:masterfrom Apr 19, 2019
Merged
Implement CS checking based on the WP_CLI_CS ruleset#119schlessera merged 4 commits intowp-cli:masterfrom
WP_CLI_CS ruleset#119schlessera merged 4 commits intowp-cli:masterfrom
Conversation
3 tasks
... as that version contains the new WPCliCS PHPCS standard.
* `.distignore`: no need to distribute the phpcs/phpunit config files.
* `.gitignore`: Allow devs to overwrite config files for PHPUnit and PHPCS
- The `.dist` files should be committed. However, for their personal use, devs can overrule those files with versions without `.dist`.
Those personal versions should never be committed.
As a side-note: for PHPCS, having a personal version while still using the original `.dist` file is made very easy, as you can just import the `.dist` file as a starting point, like so:
```xml
<?xml version="1.0"?>
<ruleset name="WP-CLI">
<rule ref="./phpcs.xml.dist"/>
</ruleset>
```
The file is completely documented in-line.
8f487bf to
e1e54fd
Compare
schlessera
approved these changes
Apr 19, 2019
WP_CLI_CS ruleset
danielbachhuber
pushed a commit
that referenced
this pull request
Nov 18, 2022
Implement CS checking based on the WPCliCS ruleset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This basically adds a PHPCS ruleset using the new WPCliCSstandard and adds a few select whitelist comments.
Please see the individual commits for more detail.
The build for this PR won't be able to pass until wp-cli-tests 2.1 has been released, upon which time, the build can just be restarted and should be green ;-)
Fixes #114
Related wp-cli/wp-cli#5179