Skip to content

Fix non static methods in Extractor_Test class call statically #5457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schlessera merged 1 commit into from
Oct 31, 2020
Merged

Fix non static methods in Extractor_Test class call statically #5457

schlessera merged 1 commit into from
Oct 31, 2020

Conversation

@ediamin
Copy link
Contributor

@ediamin ediamin commented Oct 24, 2020

The non static create_test_directory_structure and recursive_scandir methods in Extractor_Test class are called statically in same class in other methods. This PR just add static keyword to those methods and fix the problem.

@ediamin ediamin requested a review from a team as a code owner October 24, 2020 05:56
@schlessera schlessera added bug scope:testing Related to testing labels Oct 31, 2020
@schlessera schlessera added this to the 2.5.0 milestone Oct 31, 2020
@schlessera schlessera merged commit ea67204 into wp-cli:master Oct 31, 2020
@schlessera
Copy link
Member

schlessera commented Oct 31, 2020

Thanks for the PR, @ediamin !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schlessera schlessera schlessera approved these changes

Assignees

No one assigned

Labels

bug scope:testing Related to testing

Projects

None yet

Milestone

2.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@ediamin @schlessera