Skip to content

Support custom folder structures in wp-config.php file #5460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
schlessera wants to merge 3 commits into from
Closed

Support custom folder structures in wp-config.php file #5460

schlessera wants to merge 3 commits into from

Conversation

@schlessera
Copy link
Member

@schlessera schlessera commented Oct 31, 2020

Adds a regression test for wp-cli/extension-command#247

@schlessera schlessera added the scope:testing Related to testing label Oct 31, 2020
@schlessera schlessera added this to the 2.5.0 milestone Oct 31, 2020
@schlessera schlessera requested a review from a team as a code owner October 31, 2020 11:19
@schlessera
Copy link
Member Author

schlessera commented Oct 31, 2020

As I can't replicate the issue with local tests, I'll merge it to see if the test results are different for more official Phars.

@janw-me
Copy link
Member

janw-me commented Nov 4, 2020

@schlessera I pulled & switched to this branch.
And ran composer behat -- features/wp-config.feature

And get 2 errors, I guess unrelated to the problem this should address.

.F------..F----

(::) failed steps (::)

01. Notice: Undefined index: DB_USER in /home/vagrant/wp-cli-dev/wp-cli-tests/features/bootstrap/FeatureContext.php line 559
    In step `And a wp-config-override.php file:'.                                                    # /home/vagrant/wp-cli-dev/wp-cli-tests/features/steps/given.php:48
    From scenario `Default WordPress install with WP_CONFIG_PATH specified in environment variable'. # features/wp-config.feature:3
    Of feature `wp-config'.                                                                          # features/wp-config.feature

02. Notice: Undefined index: DB_USER in /home/vagrant/wp-cli-dev/wp-cli-tests/features/bootstrap/FeatureContext.php line 559
    In step `And a wp-config.php file:'.                                                             # /home/vagrant/wp-cli-dev/wp-cli-tests/features/steps/given.php:48
    From scenario `__FILE__ and __DIR__ in wp-config.php don't point into the PHAR filesystem'.      # features/wp-config.feature:42
    Of feature `wp-config'.

I'm followed the handbook.
And created the DB & user, I'm running it inside VVV
Am I missing something?

@schlessera
Copy link
Member Author

schlessera commented Nov 4, 2020

You might need to run composer install or even composer update after switching to the branch, it requires an updated wp-cli/wp-cli-tests.

@schlessera schlessera force-pushed the fix/247-custom-folder-structures-in-wp-config branch from f592370 to 6bcb7bd Compare March 5, 2021 09:59
@schlessera schlessera force-pushed the fix/247-custom-folder-structures-in-wp-config branch from 6bcb7bd to 40e5541 Compare May 8, 2021 10:24
@schlessera
Copy link
Member Author

schlessera commented May 10, 2021

Regression test was moved over to wp-cli/wp-cli-bundle#309

@schlessera schlessera closed this May 10, 2021
@schlessera schlessera deleted the fix/247-custom-folder-structures-in-wp-config branch May 10, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

scope:testing Related to testing

Projects

None yet

Milestone

2.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@schlessera @janw-me