Skip to content

Fix return type of make_progress_bar #5715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielbachhuber merged 1 commit into from
Jan 1, 2023
Merged

Fix return type of make_progress_bar #5715

danielbachhuber merged 1 commit into from
Jan 1, 2023

Conversation

@szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Dec 28, 2022

Docblocks are absolute (FQCN).

@szepeviktor szepeviktor requested a review from a team as a code owner December 28, 2022 22:18
@szepeviktor
Copy link
Contributor Author

szepeviktor commented Dec 28, 2022

The not-so-wise relative would be @return Bar|NoOp

@szepeviktor szepeviktor mentioned this pull request Dec 29, 2022
Merged
@danielbachhuber danielbachhuber added this to the 2.8.0 milestone Jan 1, 2023
@danielbachhuber danielbachhuber added the scope:documentation Related to documentation label Jan 1, 2023
danielbachhuber
danielbachhuber approved these changes Jan 1, 2023
View reviewed changes
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@danielbachhuber danielbachhuber merged commit 6af4182 into wp-cli:main Jan 1, 2023
@szepeviktor szepeviktor deleted the patch-2 branch January 1, 2023 16:12
@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jan 1, 2023

You're welcome.

@szepeviktor szepeviktor mentioned this pull request Feb 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees

No one assigned

Labels

scope:documentation Related to documentation

Projects

None yet

Milestone

2.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@szepeviktor @danielbachhuber