Skip to content

Fix failing deployments by requiring PHP 7 for some tests #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
danielbachhuber wants to merge 1 commit into from
Closed

Fix failing deployments by requiring PHP 7 for some tests #567

danielbachhuber wants to merge 1 commit into from

Conversation

@danielbachhuber
Copy link
Member

@danielbachhuber danielbachhuber commented Aug 18, 2023

No description provided.

@danielbachhuber danielbachhuber added this to the 2.9.0 milestone Aug 18, 2023
@danielbachhuber danielbachhuber self-assigned this Aug 18, 2023
@danielbachhuber danielbachhuber requested a review from a team as a code owner August 18, 2023 14:19
@swissspidy
Copy link
Member

swissspidy commented Aug 18, 2023

I think we just need to update the matrix here:

wp-cli-bundle/.github/workflows/deployment.yml

Lines 65 to 73 in 7883645

test: #----------------------------------------------------------------------
name: Functional - WP ${{ matrix.wp }} on PHP ${{ matrix.php }} with MySQL ${{ matrix.mysql }}
strategy:
fail-fast: false
matrix:
php: ['5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0']
wp: ['latest']
mysql: ['8.0']
include:

No need to test 5.6 + latest anymore

@danielbachhuber danielbachhuber removed this from the 2.9.0 milestone Aug 18, 2023
@danielbachhuber danielbachhuber mentioned this pull request Aug 18, 2023
Merged
@danielbachhuber
Copy link
Member Author

danielbachhuber commented Aug 18, 2023

I think we just need to update the matrix here:

I think you're right #568

@swissspidy swissspidy deleted the fix/require-php-7-deployment-tests branch October 1, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@danielbachhuber danielbachhuber

Labels

scope:testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielbachhuber @swissspidy