Closed
Conversation
When running composer prepare-tests and there is an errro, no usefull information is shown. Now It diesplays all the variables it uses. And when giving an error, display where to find the documentation.
swissspidy
reviewed
Feb 12, 2025
Comment on lines
+870
to
+874
| return [ | ||
| 'stdout' => $result[0], | ||
| 'stderr' => $result[1], | ||
| 'exit_code' => $result[2], | ||
| ]; |
Member
There was a problem hiding this comment.
Nit: could use array_combine here: array_combine( [ 'stdout', 'stderr', 'exit_code' ], $result )
swissspidy
reviewed
Feb 12, 2025
Comment on lines
+898
to
+902
| # WP_CLI output functions are suppressed in behat context. | ||
| echo 'There was an error connecting to the database:' . \PHP_EOL; | ||
| echo ' ' . trim( $sql_result['stderr'] ) . \PHP_EOL; | ||
| echo 'run `composer prepare-tests` to connect to the database.' . \PHP_EOL; | ||
| die( 1 ); |
Member
There was a problem hiding this comment.
👍
Maybe we could also suggest using SQLite as an alternative ? Often easiest for new contributors.
Member
|
Superseded by #261, which resolves merge conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running composer prepare-tests and there is an errro, no usefull information is shown. Now It displays all the variables it uses.
And when giving an error, display where to find the documentation.