Add ability to specify minimum mysql version requirement#266
Merged
swissspidy merged 12 commits intowp-cli:mainfrom Jul 28, 2025
Merged
Add ability to specify minimum mysql version requirement#266swissspidy merged 12 commits intowp-cli:mainfrom
swissspidy merged 12 commits intowp-cli:mainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Member
|
I like the suggestion in general 👍 For completeness, do we need the same for Some tests in |
Contributor
Author
|
@swissspidy I've updated the code, maria db and mysql now support a minimum and less than tag! 🥳 |
swissspidy
reviewed
Jul 25, 2025
swissspidy
reviewed
Jul 25, 2025
Member
swissspidy
left a comment
There was a problem hiding this comment.
Nice! Just one question, otherwise seems like a good addition!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added for #198 to allow skipping mysql 5.6