#273 :::message 記法のセマンティクス拡充#274
Merged
catnose99 merged 3 commits intozenn-dev:canaryfrom Mar 15, 2022
Merged
Conversation
catnose99
approved these changes
Mar 15, 2022
Contributor
catnose99
left a comment
There was a problem hiding this comment.
早速PRまで作っていただきありがとうございます！
一部微調整を行ったうえで取り込ませていただきます。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Summary
:::messageおよび:::message alert記法へのセマンティクスの拡充:::beforeから<svg>に<svg>にaria-labelでmessageoralertを付与あまりコーディングルール的なものがわからなかったので、リファクタリングは適宜お願いします。
CSS は基本は同じように移植してますが、検証パターンがわからなかったので確認していただけると。
Resolves #273
📋 Tasks
プルリクエストを作成いただく際、お手数ですが以下の内容についてご確認をお願いします。
canaryブランチに対するプルリクエストである