Ease debugging package loading from build_runner#508
Merged
SuperAuguste merged 1 commit intozigtools:masterfrom Jun 24, 2022
MageJohn:master
Merged
Ease debugging package loading from build_runner#508SuperAuguste merged 1 commit intozigtools:masterfrom MageJohn:master
SuperAuguste merged 1 commit intozigtools:masterfrom
MageJohn:master
Conversation
Member
|
Succinct but effective fix, thank you so much! I'll let the CI run and then merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having some issues with getting autocompletion of packages to work correctly in my project, and discovered that ZLS was ignoring exit codes other than 0, rather than reporting a failure. This PR fixes this.
I also changed the log level for package loading failure from debug to warn. If it happens it's usually a user problem, but it can look like a ZLS problem at first, so I think it's good to be proactive in telling users that there might be a problem with their build file.