fix: fix memory leaks related to updating config variables#595
Merged
leecannon merged 3 commits intozigtools:masterfrom Aug 23, 2022
llogick:master
Merged
fix: fix memory leaks related to updating config variables#595leecannon merged 3 commits intozigtools:masterfrom llogick:master
leecannon merged 3 commits intozigtools:masterfrom
llogick:master
Conversation
adds an edge case in analysis.makeScopeInternal to prevent leaking memory when adding duplicate container fields w/ name "other"
leecannon
requested changes
Aug 22, 2022
SuperAuguste
previously requested changes
Aug 22, 2022
Techatrix
approved these changes
Aug 23, 2022
leecannon
approved these changes
Aug 23, 2022
leecannon
approved these changes
Aug 23, 2022
Member
|
Thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note:
adds an edge case in analysis.makeScopeInternal to prevent
leaking memory when adding duplicate container fields w/ name "other"
but there really should be a check for duplicates
edit: