Report zls version using git describe#618
Merged
SuperAuguste merged 2 commits intozigtools:masterfrom Sep 2, 2022
Merged
Conversation
Member
Author
|
"It works on my machine" |
Member
|
I love it but this CI failure means that this won't work on build artifacts/releases :( Maybe we could add an environment variable bypass and set that environment variable to the latest commit in the CI workflow somehow? |
Member
Author
|
Adding zls/.github/workflows/main.yml Lines 17 to 19 in d72cac0 I've also seen there are new versions checkout@v3 and upload-artifact@v3 available. I am not really experienced with CI so i hope this helps.
|
Member
|
Oh awesome, feel free to adjust that in this PR! That way the CI will pass and this can be merged! :) |
SuperAuguste
approved these changes
Sep 2, 2022
Member
SuperAuguste
left a comment
There was a problem hiding this comment.
Sorry for the delay, LGTM! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outputs something like
0.9.0-210-gda03c81