fix(allure-karate): fix duplicate scenarios when call or callonce keywords are used#1144
Merged
baev merged 3 commits intoallure-framework:mainfrom Nov 29, 2024
Merged
Conversation
Contributor
Author
|
@baev I added tests and fix commit user, thank you. |
42959ac to
39db3f5
Compare
39db3f5 to
39023b8
Compare
Member
|
@umitozdemirf great job 👍, thanks. I would like to have spearate tests for Feel free to provide an additional PR with such improvements! |
baev
approved these changes
Nov 29, 2024
Contributor
Author
|
Thank you @baev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Problem
callandcalloncewere being treated as separate test scenarios.Solution
Locate the Issue:
beforeStepandafterStepmethods in theAllureKarateclass.Update
beforeStep:callorcallonce:Update
afterStep:afterStepto avoid processing them as separate tests:Test the Fix:
callandcalloncesteps now show up as part of the parent scenario, not as separate tests.Result
Checklist