feat(allure-model): add optional attachment size#1182
Merged
baev merged 1 commit intoallure-framework:mainfrom Sep 10, 2025
Merged
feat(allure-model): add optional attachment size#1182baev merged 1 commit intoallure-framework:mainfrom
baev merged 1 commit intoallure-framework:mainfrom
Conversation
5f69c28 to
2fd4cab
Compare
2 tasks
baev
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR adds an optional
sizefield to theio.qameta.allure.model.Attachmentclass to eliminateHEADHTTP roundtrips for remote attachments (when they are implemented, of course — but here it is a chicken and egg problem).This change aligns with ongoing efforts to add optional size support across Allure implementations.
See related PR in allure-js: allure-framework/allure-js#1302
Changes:
Long sizefield toAttachmentclassgetSize()andsetSize()methods following existing patternsBenefits:
Checklist