Conversation
6cc7ec8 to
d1108ba
Compare
c81ea3f to
76b9cda
Compare
|
I think this is working now, but I am confused by something. The call to For example, you can see here https://github.com/github/codeql-action/actions/runs/6791589351/job/18463369144?pr=1981#step:22:44 that there are a number of analyses that we attempt to delete, but they don't exist. They have already been deleted by another job in the workflow, ie- https://github.com/github/codeql-action/actions/runs/6791589351/job/18463373448?pr=1981#step:18:53. Two questions:
|
1c978c8 to
cac19f3
Compare
The analysis is purposefully failing. We don't want a failed analysis sitting in the security center since this can cause some internal checks to erroneously fail.
cac19f3 to
04451e0
Compare
|
This PR is now ready for review. I separated out the changes for the debug-artifacts-upload workflows, since we can and should merge that first in order to get main passing again. |
henrymercer
left a comment
There was a problem hiding this comment.
Nice, a bunch of suggestions, but this looks good.
|
Looks like we can't use the |
- Change error messages. - Use logger instead of core - throw Error instead of write error message
6f43872 to
df9b50e
Compare
henrymercer
left a comment
There was a problem hiding this comment.
Looks good, just one minor comment about the changes.
Need to also change the signature of delay to allow this to happen.
The analysis is purposefully failing. We don't want a failed analysis sitting in the security center since this can cause some internal checks to erroneously fail.
Merge / deployment checklist