fix: async-currenttarget/preventdefault doesn’t consider nested scopes#567
Merged
manuelpuyol merged 3 commits intogithub:mainfrom Dec 9, 2024
Merged
fix: async-currenttarget/preventdefault doesn’t consider nested scopes#567manuelpuyol merged 3 commits intogithub:mainfrom
manuelpuyol merged 3 commits intogithub:mainfrom
Conversation
Contributor
|
👋 @kurtextrem thanks for the contribution! Would you mind updating the tests with a new example for this case? |
Contributor
Author
Done! |
manuelpuyol
approved these changes
Dec 9, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for the eslint rules. Really helpful.
We found the following example is not caught by the rules I've updated:
The reason is, while
awaitis in the scope ofmyHandler,currentTarget(orpreventDefault()) is not. To fix it, we have to walk up the scopes and figure out if a parent scope matches the scope whereawaitwas found.