feat: add preview MultipartUploadClient#createMultipartUpload#3356
Merged
BenWhitehead merged 21 commits intostaged-mpu-merge-trainfrom Nov 3, 2025
Merged
feat: add preview MultipartUploadClient#createMultipartUpload#3356BenWhitehead merged 21 commits intostaged-mpu-merge-trainfrom
BenWhitehead merged 21 commits intostaged-mpu-merge-trainfrom
Conversation
fd13e5c to
a1f6efa
Compare
BenWhitehead
requested changes
Oct 21, 2025
...c/main/java/com/google/cloud/storage/multipartupload/model/CreateMultipartUploadRequest.java
Show resolved
Hide resolved
...c/main/java/com/google/cloud/storage/multipartupload/model/CreateMultipartUploadRequest.java
Show resolved
Hide resolved
...c/main/java/com/google/cloud/storage/multipartupload/model/CreateMultipartUploadRequest.java
Show resolved
Hide resolved
...c/main/java/com/google/cloud/storage/multipartupload/model/CreateMultipartUploadRequest.java
Outdated
Show resolved
Hide resolved
...oud-storage/src/main/java/com/google/cloud/storage/multipartupload/model/ObjectLockMode.java
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/MultipartUploadClientImpl.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/MultipartUploadClientImpl.java
Outdated
Show resolved
Hide resolved
...-cloud-storage/src/main/java/com/google/cloud/storage/MultipartUploadHttpRequestManager.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/test/java/com/google/cloud/storage/MultipartUploadClientImplTest.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/test/java/com/google/cloud/storage/MultipartUploadClientImplTest.java
Outdated
Show resolved
Hide resolved
BenWhitehead
requested changes
Oct 22, 2025
...oud-storage/src/main/java/com/google/cloud/storage/multipartupload/model/ObjectLockMode.java
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/XmlObjectParser.java
Outdated
Show resolved
Hide resolved
...-storage/src/test/java/com/google/cloud/storage/ITMultipartUploadHttpRequestManagerTest.java
Outdated
Show resolved
Hide resolved
...-storage/src/test/java/com/google/cloud/storage/ITMultipartUploadHttpRequestManagerTest.java
Show resolved
Hide resolved
...-storage/src/test/java/com/google/cloud/storage/ITMultipartUploadHttpRequestManagerTest.java
Outdated
Show resolved
Hide resolved
...-storage/src/test/java/com/google/cloud/storage/ITMultipartUploadHttpRequestManagerTest.java
Show resolved
Hide resolved
BenWhitehead
requested changes
Oct 23, 2025
...-cloud-storage/src/main/java/com/google/cloud/storage/MultipartUploadHttpRequestManager.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/MultipartUploadClientImpl.java
Outdated
Show resolved
Hide resolved
ShreyasSinha
commented
Oct 24, 2025
Collaborator
Author
ShreyasSinha
left a comment
There was a problem hiding this comment.
Added refactoring changes in this PR only.
google-cloud-storage/src/main/java/com/google/cloud/storage/MultipartUploadClientImpl.java
Outdated
Show resolved
Hide resolved
Collaborator
|
No more requested changes for this PR at this time, but we do have some followups later. Holding off merging for now. |
10 tasks
BenWhitehead
approved these changes
Oct 31, 2025
Collaborator
BenWhitehead
left a comment
There was a problem hiding this comment.
ready for merge train
BenWhitehead
added a commit
that referenced
this pull request
Nov 3, 2025
BEGIN_NESTED_COMMIT BEGIN_COMMIT_OVERRIDE feat: add preview MultipartUploadClient#createMultipartUpload #3356 END_COMMIT_OVERRIDE BEGIN_COMMIT_OVERRIDE feat: add preview MultipartUploadClient#listParts #3359 END_COMMIT_OVERRIDE BEGIN_COMMIT_OVERRIDE feat: add preview MultipartUploadClient#abortMultipartUpload #3361 END_COMMIT_OVERRIDE BEGIN_COMMIT_OVERRIDE feat: add preview MultipartUploadClient#uploadPart #3375 END_COMMIT_OVERRIDE BEGIN_COMMIT_OVERRIDE feat: add preview MultipartUploadClient#completeMultipartUpload #3372 END_COMMIT_OVERRIDE BEGIN_COMMIT_OVERRIDE feat: add preview MultipartUploadSettings END_COMMIT_OVERRIDE BEGIN_COMMIT_OVERRIDE END_COMMIT_OVERRIDE END_NESTED_COMMIT Other changes: 1. chore: refactor retrier creation from HttpStorageOptions to StorageOptions #3350 2. chore: refactorings for CreateMultipartUpload #3364 3. chore: fix xml parsing of StringEnumValue's so that the enum contract is not broken #3377 4. chore: add PredefinedAcl#xmlEntry Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
BenWhitehead
added a commit
that referenced
this pull request
Nov 3, 2025
BEGIN_NESTED_COMMIT BEGIN_COMMIT_OVERRIDE feat: add preview MultipartUploadClient#createMultipartUpload #3356 END_COMMIT_OVERRIDE BEGIN_COMMIT_OVERRIDE feat: add preview MultipartUploadClient#listParts #3359 END_COMMIT_OVERRIDE BEGIN_COMMIT_OVERRIDE feat: add preview MultipartUploadClient#abortMultipartUpload #3361 END_COMMIT_OVERRIDE BEGIN_COMMIT_OVERRIDE feat: add preview MultipartUploadClient#uploadPart #3375 END_COMMIT_OVERRIDE BEGIN_COMMIT_OVERRIDE feat: add preview MultipartUploadClient#completeMultipartUpload #3372 END_COMMIT_OVERRIDE BEGIN_COMMIT_OVERRIDE feat: add preview MultipartUploadSettings END_COMMIT_OVERRIDE BEGIN_COMMIT_OVERRIDE END_COMMIT_OVERRIDE END_NESTED_COMMIT Other changes: 1. chore: refactor retrier creation from HttpStorageOptions to StorageOptions #3350 2. chore: refactorings for CreateMultipartUpload #3364 3. chore: fix xml parsing of StringEnumValue's so that the enum contract is not broken #3377 4. chore: add PredefinedAcl#xmlEntry Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
BenWhitehead
added a commit
that referenced
this pull request
Nov 3, 2025
BEGIN_NESTED_COMMIT BEGIN_COMMIT_OVERRIDE feat: add preview MultipartUploadClient#createMultipartUpload #3356 END_COMMIT_OVERRIDE BEGIN_COMMIT_OVERRIDE feat: add preview MultipartUploadClient#listParts #3359 END_COMMIT_OVERRIDE BEGIN_COMMIT_OVERRIDE feat: add preview MultipartUploadClient#abortMultipartUpload #3361 END_COMMIT_OVERRIDE BEGIN_COMMIT_OVERRIDE feat: add preview MultipartUploadClient#uploadPart #3375 END_COMMIT_OVERRIDE BEGIN_COMMIT_OVERRIDE feat: add preview MultipartUploadClient#completeMultipartUpload #3372 END_COMMIT_OVERRIDE BEGIN_COMMIT_OVERRIDE feat: add preview MultipartUploadSettings END_COMMIT_OVERRIDE BEGIN_COMMIT_OVERRIDE END_COMMIT_OVERRIDE END_NESTED_COMMIT Other changes: 1. chore: refactor retrier creation from HttpStorageOptions to StorageOptions #3350 2. chore: refactorings for CreateMultipartUpload #3364 3. chore: fix xml parsing of StringEnumValue's so that the enum contract is not broken #3377 4. chore: add PredefinedAcl#xmlEntry Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
Collaborator
|
merged to main in #3378 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer: #3348