core: PF.requestConnection() is possible when READY

ejona86 · ejona86 · commit 2c93791c985e · 2024-08-21T07:16:29.000-07:00
requestConnection() is public API, and it is allowed to be called even
if the load balancer is already READY.
diff --git a/core/src/main/java/io/grpc/internal/PickFirstLeafLoadBalancer.java b/core/src/main/java/io/grpc/internal/PickFirstLeafLoadBalancer.java
@@ -395,12 +395,8 @@ public void requestConnection() {
         addressIndex.increment();
         requestConnection();
         break;
-      case READY: // Shouldn't ever happen
-        log.warning("Requesting a connection even though we have a READY subchannel");
-        break;
-      case SHUTDOWN:
       default:
-        // Makes checkstyle happy
+        // Wait for current subchannel to change state
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -395,12 +395,8 @@ public void requestConnection() {`
`395`	`395`	`addressIndex.increment();`
`396`	`396`	`requestConnection();`
`397`	`397`	`break;`
`398`		`- case READY: // Shouldn't ever happen`
`399`		`- log.warning("Requesting a connection even though we have a READY subchannel");`
`400`		`- break;`
`401`		`- case SHUTDOWN:`
`402`	`398`	`default:`
`403`		`- // Makes checkstyle happy`
	`399`	`+ // Wait for current subchannel to change state`
`404`	`400`	`}`
`405`	`401`	`}`
`406`	`402`