Stub out copilotRelated command#60488
Merged
sandersn merged 4 commits intomicrosoft:mainfrom Nov 13, 2024
Merged
Conversation
It will return an empty array in 5.7, and should be removed entirely in Typescript 5.8. The only client should be VSCode 1.95.
Collaborator
|
Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @mjbvz, @zkat, and @joj for you. Feel free to loop in other consumers/maintainers if necessary. |
Collaborator
|
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
This was referenced Nov 12, 2024
jakebailey
reviewed
Nov 12, 2024
The remaining private method returns an object type
jakebailey
approved these changes
Nov 13, 2024
Member
Author
|
@typescript-bot cherry-pick this |
Member
Author
|
@typescript-bot cherry-pick |
Member
Author
|
@typescript-bot cherry-pick to release-5.7 |
Collaborator
typescript-bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature didn't help, but it took a long time to verify that.
The copilotRelated command will return an empty array in 5.7, and should be removed entirely in Typescript 5.8.
The only client should be VSCode 1.95. Matching PR to remove it from the typescript extension: microsoft/vscode#233729.