test: check --test is disallowed in NODE_OPTIONS#44846
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Oct 7, 2022
Merged
test: check --test is disallowed in NODE_OPTIONS#44846nodejs-github-bot merged 1 commit intonodejs:mainfrom
--test is disallowed in NODE_OPTIONS#44846nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
RaisinTen
approved these changes
Oct 1, 2022
Collaborator
cjihrig
approved these changes
Oct 1, 2022
lpinca
approved these changes
Oct 1, 2022
daeyeon
approved these changes
Oct 2, 2022
bnb
approved these changes
Oct 2, 2022
jasnell
approved these changes
Oct 2, 2022
This was referenced Oct 3, 2022
himself65
approved these changes
Oct 6, 2022
Collaborator
Collaborator
|
Landed in 2c57b94 |
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
PR-URL: #44846 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #42658 (comment)