Clear more data in TypeChecker.reset() instead of asserting#19087
Merged
svalentin merged 1 commit intopython:masterfrom May 13, 2025
Merged
Clear more data in TypeChecker.reset() instead of asserting#19087svalentin merged 1 commit intopython:masterfrom
svalentin merged 1 commit intopython:masterfrom
Conversation
Running mypy daemon on internal Dropbox codebase can cause an Assertion Error: ``` version: 1.16.0+dev.ca609acabdc94ee973a53d62b8dcb7e55c789aec Daemon crashed! Traceback (most recent call last): File "mypy/dmypy_server.py", line 237, in serve File "mypy/dmypy_server.py", line 286, in run_command File "mypy/dmypy_server.py", line 364, in cmd_check File "mypy/dmypy_server.py", line 428, in check File "mypy/dmypy_server.py", line 517, in initialize_fine_grained File "mypy/server/update.py", line 265, in update File "mypy/server/update.py", line 367, in update_one File "mypy/server/update.py", line 432, in update_module File "mypy/server/update.py", line 672, in update_module_isolated File "mypy/build.py", line 2410, in finish_passes File "mypy/build.py", line 2417, in free_state File "mypy/checker.py", line 443, in reset AssertionError ``` Let's convert these asserts in reset() to actual cleanup. I see no reason not to clean them up. It also seems safe for this particular crash, since in File "mypy/build.py", line 2417, in free_state right after this line there's `self._type_checker = None`. So even if we wer not to call reset() everything would still be correct.
JukkaL
approved these changes
May 13, 2025
Collaborator
JukkaL
left a comment
There was a problem hiding this comment.
This looks reasonable at least as a temporary fix, but the assertion failure may be a symptom of another problem, so we should investigate this in more detail before the next release.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running mypy daemon on internal Dropbox codebase can cause an AssertionError:
Let's convert these asserts in reset() to actual cleanup. I see no reason not to clean them up.
It also seems safe for this particular crash, since in File "mypy/build.py", line 2417, in free_state
right after this line there's
self._type_checker = None. So even if we wer not to call reset() everything would still be correct.Alternatively, we can just reset everything by calling
__init__with original args: