Allow orphan terms to be exported with --allow_orphan_terms flag#109
Merged
danielbachhuber merged 10 commits intowp-cli:mainfrom Sep 18, 2023
Merged
Allow orphan terms to be exported with --allow_orphan_terms flag#109danielbachhuber merged 10 commits intowp-cli:mainfrom
--allow_orphan_terms flag#109danielbachhuber merged 10 commits intowp-cli:mainfrom
Conversation
1 task
danielbachhuber
requested changes
Aug 29, 2023
Member
danielbachhuber
left a comment
There was a problem hiding this comment.
Looks pretty solid 👍 Just a few nits to polish up.
danielbachhuber
approved these changes
Sep 18, 2023
Member
danielbachhuber
left a comment
There was a problem hiding this comment.
Great work on this, @jacksonwp. I made a few additional tweaks you might want to look through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #108
This PR adds a flag
--allow_orphan_terms, that when set allows the export to proceed when orphan terms are found.When the flag is set, the orphaned terms have their parent set to 0 and the export proceeds.
When the flag is not set, an exception is thrown and the export fails.
Related wp-cli/wp-cli#5832