HttpRequest.__init__ remove useless mimeparse#467
Merged
theacodes merged 1 commit intogoogleapis:masterfrom Jan 19, 2018
xmedeko:http_init
Merged
HttpRequest.__init__ remove useless mimeparse#467theacodes merged 1 commit intogoogleapis:masterfrom xmedeko:http_init
theacodes merged 1 commit intogoogleapis:masterfrom
xmedeko:http_init
Conversation
Contributor
|
@xmedeko this might be useful, can you add a test that demonstrates the case? |
Contributor
Author
|
A test code is in the #284. Do you mean a test into the |
Contributor
|
yes
…On Wed, Jan 17, 2018 at 11:05 AM Ondrej Medek ***@***.***> wrote:
A test code is in the #284
<#284>. Do you
mean a test into the test_http.py?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#467 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPUc5p3tbC9NjJnkOwRu45WXWLUd_C9ks5tLkSIgaJpZM4RhlII>
.
|
Contributor
Author
|
Added a simple test of |
Contributor
|
Thanks, @xmedeko |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #284