DEP: Deprecate 4 ndarray.ctypes methods#19031
Merged
seberg merged 7 commits intonumpy:mainfrom May 18, 2021
Merged
Conversation
added 3 commits
May 18, 2021 17:54
* `get_data` * `get_shape` * `get_strides` * `get_as_parameter`
seberg
reviewed
May 18, 2021
Co-Authored-By: Sebastian Berg <sebastian@sipsolutions.net>
eric-wieser
reviewed
May 18, 2021
eric-wieser
reviewed
May 18, 2021
Co-Authored-By: Eric Wieser <425260+eric-wieser@users.noreply.github.com>
Co-Authored-By: Eric Wieser <425260+eric-wieser@users.noreply.github.com>
eric-wieser
approved these changes
May 18, 2021
Member
|
Thanks! That one travis run has beeing making problems. I am going to put it in, since I don't expect complains on the mailing list. If they come, happy to revert :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xref #19029 (comment).
Four methods of the
ndarray.ctypesobject have been deprecated, as they are (undocumentated) implementation artifacts of their respective property. They were originally kept around for the sake of backwards compatibility (79baef7), but as this was three years ago it should be safe to formally deprecate them by now.numpy/numpy/core/_internal.py
Lines 353 to 357 in bfb1ac8